-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codegen filter to ModelV2 #7898
Conversation
590c43f
to
19a2ddb
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7898 +/- ##
============================================
+ Coverage 36.88% 36.95% +0.07%
Complexity 2213 2213
============================================
Files 1253 1254 +1
Lines 113838 113987 +149
Branches 3185 3185
============================================
+ Hits 41991 42128 +137
- Misses 69955 69967 +12
Partials 1892 1892
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
14a7f6f
to
7ba0bce
Compare
7ba0bce
to
ce99879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the fact that we haven't seen any improvement in compilation time seems to indicate that ModelV2 may not be the source of the problem.
4ee7ddc
to
c34c7b5
Compare
c34c7b5
to
f16fb75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok but as stated by @flomonster, if we don't see any compilation improvement, do we need the additional complexity?
@woshilapin I drafted this PR a while ago hoping it would help with compilation times. It didn't help so I abandoned the idea. However @Castavo noticed a problem with models having only a single primary key (such as |
30ede7f
to
83ff709
Compare
83ff709
to
3e58cbb
Compare
Adds an option to parametrize which implementation ModelV2 has to generate. This is required to support single PK field models (such as
Timetable
).No impact on compilation times.
refs #8111